Youtube: add plugin for viewing videos/channels #6740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrisXV
reviewed
May 24, 2020
Co-authored-by: Kris Johnson <11083252+KrisXV@users.noreply.github.com>
I felt it fit here, since it uses |
|
(requesting since they ran the plugin on the bot, so i thought input from them might be helpful - lmk if I shouldn't have done that) |
will be in a different commit
|
Removed approvals/link for now. |
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly for the youtube room. However, /requestapproval and /link are meant for all rooms, since they're very commonly used through Kid A and very useful, and can be streamlined a bit here (they're in this plugin so they can make use of the Youtube interface.)
Specifics are here https://www.smogon.com/forums/threads/youtube-channel-database.3664726/.
This has been approved by both Kie and A Random Duck.
As for the Config setting for the api key, i have a key that can be used, and can share privately for someone who can set that.